Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added toggleClass to AdaptModel and ItemModel #593

Merged
merged 2 commits into from
Oct 22, 2024
Merged

New: Added toggleClass to AdaptModel and ItemModel #593

merged 2 commits into from
Oct 22, 2024

Conversation

oliverfoster
Copy link
Member

fixes #592

New

  • toggleModelClass(model, className, hasClass) in modelHelpers.js
  • AdaptModel.prototype.toggleClass(className, hasClass)
  • ItemModel.prototype.toggleClass(className, hasClass)

@oliverfoster oliverfoster added the enhancement New feature or request label Oct 16, 2024
@oliverfoster oliverfoster self-assigned this Oct 16, 2024
@oliverfoster oliverfoster mentioned this pull request Oct 16, 2024
Merged
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

swashbuck
swashbuck approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swashbuck swashbuck mentioned this pull request Oct 21, 2024
Merged
kirsty-hames
kirsty-hames approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with #595 and works as expected thanks 👍

@joe-allen-89 joe-allen-89 merged commit a500a54 into master Oct 22, 2024
@joe-allen-89 joe-allen-89 deleted the issue/592 branch October 22, 2024 11:33
github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
@semantic-release-bot
Chore(release): 6.59.0
fda4c9e 
# [6.59.0](v6.58.0...v6.59.0) (2024-10-22)

### New

* Added toggleClass to AdaptModel and ItemModel (fixes #593) ([a500a54](a500a54)), closes [#593](#593)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.59.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@swashbuck swashbuck swashbuck approved these changes

Assignees

@oliverfoster oliverfoster

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add toggleClass to models
5 participants
@oliverfoster @swashbuck @kirsty-hames @cahirodoherty-learningpool @joe-allen-89